[PATCH] D103263: [AArch64] Add S/UQXTRN tablegen patterns.

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen accepted this revision.
sdesmalen added a comment.

LGTM if you fix `s/EF/7F/` before you land it!



================
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.td:4232
+def VImm80:   PatLeaf<(AArch64mvni_shift (i32 127), (i32 0))>;
+def VImmEFFF: PatLeaf<(AArch64movi_msl (i32 127), (i32 264))>;
+def VImm8000: PatLeaf<(AArch64mvni_msl (i32 127), (i32 264))>;
----------------
It is nearly impossible to understand how these PatLeafs work, but that's nothing to do with your patch, since BuildVectors are lowered earlier on. It would be nice if these would just have been `dup()` nodes instead, but I'll just rely on the tests that you have implemented these PatLeafs correctly. At least the names of the PatLeafs (when you fix s/EF/7F/) make it a bit more understandable, thanks for making that change!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103263/new/

https://reviews.llvm.org/D103263