[PATCH] D105095: [Coroutine] Add statistics for the number of elided coroutine
Nico Weber via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 30 07:08:13 PDT 2021
thakis added a comment.
Hello :)
This makes Transforms/Coroutines/coro-elide.ll fail on mac/linux/windows in a PGO build. The following builds first build clang, then build clang with just-built clang with PGO instrumentation enabled, then run it to generate profiles, and then build things a third time with profiles (and LTO on linux and win). When running tests after the third build, this test fails:
https://ci.chromium.org/ui/p/chromium/builders/try/win_upload_clang/1646/overview => https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8843025821336802800/+/u/package_clang/stdout?format=raw
https://ci.chromium.org/ui/p/chromium/builders/try/mac_upload_clang/1786/overview => https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8843025821336802832/+/u/package_clang/stdout?format=raw
https://ci.chromium.org/ui/p/chromium/builders/try/linux_upload_clang/1634/overview => https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8843025821336802848/+/u/package_clang/stdout?format=raw
Pasting the failure output from the linux bot:
build/Release+Asserts/bin/clang
llvm-lit: /b/s/w/ir/cache/builder/src/third_party/llvm/llvm/utils/lit/lit/llvm/config.py:436: note: using clang: /b/s/w/ir/cache/builder/src/third_party/llvm-build/Release+Asserts/bin/clang
llvm-lit: /b/s/w/ir/cache/builder/src/third_party/llvm/llvm/utils/lit/lit/llvm/config.py:436: note: using ld.lld: /b/s/w/ir/cache/builder/src/third_party/llvm-build/Release+Asserts/bin/ld.lld
llvm-lit: /b/s/w/ir/cache/builder/src/third_party/llvm/llvm/utils/lit/lit/llvm/config.py:436: note: using lld-link: /b/s/w/ir/cache/builder/src/third_party/llvm-build/Release+Asserts/bin/lld-link
llvm-lit: /b/s/w/ir/cache/builder/src/third_party/llvm/llvm/utils/lit/lit/llvm/config.py:436: note: using ld64.lld: /b/s/w/ir/cache/builder/src/third_party/llvm-build/Release+Asserts/bin/ld64.lld
llvm-lit: /b/s/w/ir/cache/builder/src/third_party/llvm/llvm/utils/lit/lit/llvm/config.py:436: note: using wasm-ld: /b/s/w/ir/cache/builder/src/third_party/llvm-build/Release+Asserts/bin/wasm-ld
llvm-lit: /b/s/w/ir/cache/builder/src/third_party/llvm-build/Release+Asserts/utils/lit/tests/lit.cfg:89: warning: Setting a timeout per test not supported. Requires the Python psutil module but it could not be found. Try installing it via pip or via your operating system's package manager.
Some tests will be skipped and the --timeout command line argument will not work.
-- Testing: 84534 tests, 32 workers --
Testing: 0.. 10.. 20.. 30.. 40.. 50.. 60.. 70
FAIL: LLVM :: Transforms/Coroutines/coro-elide.ll (61622 of 84534)
******************** TEST 'LLVM :: Transforms/Coroutines/coro-elide.ll' FAILED ********************
Script:
--
: 'RUN: at line 3'; /b/s/w/ir/cache/builder/src/third_party/llvm-build/Release+Asserts/bin/opt < /b/s/w/ir/cache/builder/src/third_party/llvm/llvm/test/Transforms/Coroutines/coro-elide.ll -S -passes='cgscc(repeat<2>(inline,function(coro-elide,dce)))' -stats 2>&1 | /b/s/w/ir/cache/builder/src/third_party/llvm-build/Release+Asserts/bin/FileCheck /b/s/w/ir/cache/builder/src/third_party/llvm/llvm/test/Transforms/Coroutines/coro-elide.ll --check-prefixes=CHECK,STATS
--
Exit Code: 1
Command Output (stderr):
--
/b/s/w/ir/cache/builder/src/third_party/llvm/llvm/test/Transforms/Coroutines/coro-elide.ll:168:10: error: STATS: expected string not found in input
; STATS: 2 coro-elide - The # of coroutine get elided.
^
<stdin>:105:10: note: scanning from here
ret void
^
<stdin>:125:1: note: possible intended match here
attributes #2 = { nounwind readnone }
^
Input file: <stdin>
Check file: /b/s/w/ir/cache/builder/src/third_party/llvm/llvm/test/Transforms/Coroutines/coro-elide.ll
-dump-input=help explains the following input dump.
Input was:
<<<<<<
.
.
.
100: %1 = bitcast i8* %0 to void (i8*)*
101: call fastcc void %1(i8* %hdl)
102: %2 = call i8* @llvm.coro.subfn.addr(i8* %hdl, i8 1)
103: %3 = bitcast i8* %2 to void (i8*)*
104: call fastcc void %3(i8* %hdl)
105: ret void
check:168'0 X error: no match found
106: }
check:168'0 ~~
107:
check:168'0 ~
108: ; Function Attrs: argmemonly nounwind readonly
check:168'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
109: declare token @llvm.coro.id(i32, i8* readnone, i8* nocapture readonly, i8*) #1
check:168'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
110:
check:168'0 ~
.
.
.
120: ; Function Attrs: nounwind
check:168'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~
121: declare i1 @llvm.coro.alloc(token) #0
check:168'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
122:
check:168'0 ~
123: attributes #0 = { nounwind }
check:168'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
124: attributes #1 = { argmemonly nounwind readonly }
check:168'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
125: attributes #2 = { nounwind readnone }
check:168'0 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
check:168'1 ? possible intended match
>>>>>>
--
********************
Testing: 0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..
********************
Failed Tests (1):
LLVM :: Transforms/Coroutines/coro-elide.ll
Please take a look, or revert for now if it takes a while to fix.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105095/new/
https://reviews.llvm.org/D105095
More information about the llvm-commits
mailing list