[PATCH] D50524: [Hexagon] Replace fatal error with remark in HexagonISelLowering

Krzysztof Parzyszek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 30 06:41:46 PDT 2021


kparzysz added inline comments.


================
Comment at: llvm/lib/Target/Hexagon/HexagonISelLowering.cpp:1978
+  return Trap;
 }
 
----------------
bcain wrote:
> Do the tests cover all of the new paths defined here? 
Turns out it's impossible to get an indexed load/store to an immediate address, since DAG combiner will simply generate the updated address directly, instead of relying on pre- or post-increment.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D50524/new/

https://reviews.llvm.org/D50524



More information about the llvm-commits mailing list