[PATCH] D105100: [NFC] Add new setDebugLocFromInst that uses the class Builder by default

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 30 05:49:19 PDT 2021


sdesmalen added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:552
+  /// \p V. If \p Ptr is None then it uses the class member's Builder.
+  void setDebugLocFromInst(Optional<IRBuilder<> *> Ptr, const Value *V);
 
----------------
If you make this the second operand, you can make it a default parameter, e.g. `Optional<IRBuilder<> *> Ptr = None`, so you don't need to pass None to each of the calls.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105100/new/

https://reviews.llvm.org/D105100



More information about the llvm-commits mailing list