[PATCH] D104672: [Orc] At CBindings for LazyRexports

[Lang Hames via Phabricator via llvm-commits]

lhames added a comment.

The patch will also need to be clang-formatted.



================
Comment at: llvm/include/llvm-c/Orc.h:845
+ */
+LLVMOrcIndirectStubsManagerRef LLVMOrcCreateLocalIndirectStubsManager(
+    const char *TargetTriple);
----------------
lhames wrote:
> This is actually returning a stubs-manager-builder -- a factory that produces stub-manager objects. This is a hangover from OrcV1 and should be replaced with a simpler stub manager object, we just haven't gotten around to it yet.
> 
> Sadly, for the sake of consistency, we probably need to rename the type and API to `LLVMOrcIndirectStubsManagerBuilderRef` and `LLVMOrcCreateLocalIndirectStubsManagerBuilder`.
Oh, I missed that the implementation was actually running the builder and returning an instance, not returning the builder. Scratch this comment -- these APIs are named correctly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104672/new/

https://reviews.llvm.org/D104672