[PATCH] D97106: [UpdateTestChecks] Warn if any function conflicts under the same prefix

[Kai Luo via Phabricator via llvm-commits]

lkail added a comment.

This patch looks worthy pursuing. We have some tests under `test/CodeGen/PowerPC` uses `-check-prefixes=A,B,C` and got conflicts when updating them.



================
Comment at: llvm/utils/UpdateTestChecks/common.py:275
   def finish_and_get_func_dict(self):
-    for prefix in self._get_failed_prefixes():
-      warn('Prefix %s had conflicting output from different RUN lines for all functions' % (prefix,))
+    for prefix, funcs in self._get_failed_prefixes():
+      warn('Prefix %s had conflicting output from different RUN lines for functions: %s' % (
----------------
pengfei wrote:
> I think the warn only conflicting for all functions is used for the multi prefixes case, e.g. `--check-prefixes=A,B;--check-prefixes=A,C` when we hope the conflicted functions use B and C respectively. Under which case, warn A conflicted is annoying.
Agree.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97106/new/

https://reviews.llvm.org/D97106