[PATCH] D105115: [ConstantRanges] Use APInt for constant case for urem/srem.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 30 01:37:08 PDT 2021


fhahn marked an inline comment as done.
fhahn added inline comments.


================
Comment at: llvm/lib/IR/ConstantRange.cpp:1224
 
+  if (RHS.isSingleElement()) {
+    const APInt &RHSInt = *RHS.getSingleElement();
----------------
nikic wrote:
> This should be `if (const APInt *RHSInt = RHS.getSingleElement())`. Same for the other isSingleElement + getSingleElement combinations.
Updated, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105115/new/

https://reviews.llvm.org/D105115



More information about the llvm-commits mailing list