[PATCH] D99355: Implementation of intrinsic and SDNode definitions for VP load, store, gather, scatter.

[Simon Moll via Phabricator via llvm-commits]

simoll added a comment.

Apart from a style nit, LGTM. Will run some local tests before accepting. Thx!



================
Comment at: llvm/unittests/IR/VPIntrinsicTest.cpp:248
     std::vector<Value *> Values;
-    for (auto *ParamTy : FuncTy->params())
-      Values.push_back(UndefValue::get(ParamTy));
+    for (auto *ParamTy : FuncTy->params()) {
+      Values.push_back(UndefValue::get(ParamTy));}
----------------
No  braces


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99355/new/

https://reviews.llvm.org/D99355