[PATCH] D95807: [Coroutines] Add the newly generated SCCs back to the CGSCC work queue after CoroSplit actually happened

Chuanqi Xu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 29 20:23:08 PDT 2021


ChuanqiXu added a comment.

In D95807#2849128 <https://reviews.llvm.org/D95807#2849128>, @lxfind wrote:

>> If coroutine ramp function couldn't get inlined, it would disable coroutine elide optimization. Could you elaborate more on why do you want to do that?
>
> Ramp function will eventually be inlined, but not when you run Inliner on the inlinee.
> Let's say coroutine A calls coroutine B, and eventually we want to inline B into A so that we could perform CoroElide on A.
> After B is split, we don't need to run inliner again on B. When we run inliner on A, A will inline B.

Thanks for clarifying.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95807/new/

https://reviews.llvm.org/D95807



More information about the llvm-commits mailing list