[PATCH] D95807: [Coroutines] Add the newly generated SCCs back to the CGSCC work queue after CoroSplit actually happened

Xun Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 29 20:12:20 PDT 2021


lxfind added a comment.

In D95807#2849053 <https://reviews.llvm.org/D95807#2849053>, @aeubanks wrote:

> this will run the function simplification pipeline twice on every single function when coroutines are enabled, I don't think that's the intention
>
> I thought the intention was to do all the the re-adding of SCCs inside CoroSplit.cpp, including the SCC with the function that was split

Good point. I was trying to avoid the second inliner on the coroutine ramp function. But I guess the cost will be bigger than the win.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95807/new/

https://reviews.llvm.org/D95807



More information about the llvm-commits mailing list