[PATCH] D105162: Avoid misleading line table when Localizer sinks an instruction to another basic block

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 29 17:16:29 PDT 2021


aprantl created this revision.
aprantl added reviewers: vsk, aemerson, dsanders.
Herald added a subscriber: hiraditya.
aprantl requested review of this revision.
Herald added a project: LLVM.

This patch attaches the source location of the insertion point to the localized instruction, if it comes from a different basic block. Preserving the original source location would create a misleading line table.

Cf. https://www.llvm.org/docs/HowToUpdateDebugInfo.html#when-to-drop-an-instruction-location

rdar://78489600


https://reviews.llvm.org/D105162

Files:
  llvm/lib/CodeGen/GlobalISel/Localizer.cpp
  llvm/test/DebugInfo/MIR/AArch64/localizer.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D105162.355408.patch
Type: text/x-patch
Size: 6071 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210630/71ccd34b/attachment.bin>


More information about the llvm-commits mailing list