[PATCH] D105104: [AMDGPU] PHI node cost should not be counted for the size and latency.

Daniil Fukalov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 29 15:51:56 PDT 2021


dfukalov added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.cpp:841
-  case Instruction::PHI:
-    // TODO: 1. A prediction phi won't be eliminated?
-    //       2. Estimate data copy instructions in this case.
----------------
Nit: leave this or similar related todo comments somewhere, it wasn't done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105104/new/

https://reviews.llvm.org/D105104



More information about the llvm-commits mailing list