[PATCH] D104408: AMDGPU/GlobalISel: Do not fcanonicalize const splat padded with undef

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 29 15:06:07 PDT 2021


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:9714
+  if (mi_match(Reg, MRI, MIPatternMatch::FCstOrSplatFCstRegMatch(FCst))) {
+    auto F = getConstantFPVRegVal(FCst, MRI)->getValueAPF();
+    if (F.isSignaling())
----------------
If the matcher is finding it's a constant, why does it return the register instead of the direct APFloat?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104408/new/

https://reviews.llvm.org/D104408



More information about the llvm-commits mailing list