[PATCH] D104572: [lit] Add the ability to parse regexes in Lit boolean expressions

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added a comment.

In D104572#2848461 <https://reviews.llvm.org/D104572#2848461>, @ldionne wrote:

> In D104572#2848282 <https://reviews.llvm.org/D104572#2848282>, @jdenny wrote:
>
>> I've seen these groups but haven't investigated how they work.  Is the idea that someone from that group must accept or the patch is marked as blocked?
>
> Yes, basically the review is marked as blocked until anyone from the group gives a green check-mark. It's also possible to make the group a non-blocking reviewer (or even just a subscriber). But having that helps making sure that everybody in the group will be pinged when a review is posted.

Makes sense to me.  FileCheck could probably use this too.  In either case, whether we need a blocking group isn't clear to me yet, so I'll have to defer to others on that point.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104572/new/

https://reviews.llvm.org/D104572