[PATCH] D104572: [lit] Add the ability to parse regexes in Lit boolean expressions

Tue Jun 29 13:06:15 PDT 2021

jdenny added a comment.

In D104572#2848130 <https://reviews.llvm.org/D104572#2848130>, @ldionne wrote:

> Thanks a lot for the review! Waiting for a bit is not frustrating - I fully understand how everybody's busy and I myself often let reviews go under my radar for a while. I'll wait until the end of the week to commit this.

Thanks for understanding, and for the patch!

In D104572#2848143 <https://reviews.llvm.org/D104572#2848143>, @ldionne wrote:

> Also, as a side note - should we perhaps create a Lit review group that people can add themselves to, and that is added as a blocking reviewer on any review that touches `llvm/utils/lit`? I think that might be useful, as I'm never certain of who should be included on those reviews. We have that for libc++ and it's working out pretty well.

I've seen these groups but haven't investigated how they work.  Is the idea that someone from that group must accept or the patch is marked as blocked?

================
Comment at: llvm/docs/TestingGuide.rst:465-468
+- Any Python regular expression enclosed in ``{{ }}``, in which case the boolean
+  expression is satisfied if any feature matches the regular expression. Also note
+  that regular expressions can appear inside an identifier, so for example
+  ``he{{l+}}o`` would match ``helo``, ``hello``, ``helllo``, and so on.
----------------
ldionne wrote:
> jdenny wrote:
> > Thanks for adding this.
> > 
> > Tiny nit: The second bullet is a different animal than the other two.  I'd put the other two next to each other or integrate them.  But it's no big deal if you prefer it as is.
> Hmm, yes, I agree with you. I integrated both into one paragraph, and I documented the fact that string comparison is case sensitive while I was at it.
> 
> Please let me know if the new formulation doesn't suit you.
LGTM.  Thanks.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104572/new/

https://reviews.llvm.org/D104572