[PATCH] D105118: [remangleIntrinsicFunction] Detect and resolve name clash

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 29 12:45:08 PDT 2021


efriedma added inline comments.


================
Comment at: llvm/lib/IR/Function.cpp:1670
+  if (ExistingF) {
+    if (cast<Function>(ExistingF)->getFunctionType() == F->getFunctionType()) {
+      NewDecl = cast<Function>(ExistingF);
----------------
Probably better not to assume the GlobalValue is a Function.  Probably an invalid module if it isn't a function, but we might not check for that until later.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105118/new/

https://reviews.llvm.org/D105118



More information about the llvm-commits mailing list