[PATCH] D105128: [dfsan] Expose dfsan_get_track_origins to get origin tracking status

Andrew via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 29 12:37:15 PDT 2021


browneee added inline comments.


================
Comment at: compiler-rt/include/sanitizer/dfsan_interface.h:145
+
+/// Returns the value of -dfsan-track-origins.
+int dfsan_get_track_origins(void);
----------------
Comment here should explain the meaning of different return values, or link to something that does.


================
Comment at: compiler-rt/lib/dfsan/dfsan.cpp:55
 
 // Instrumented code may set this value in terms of -dfsan-track-origins.
 // * undefined or 0: do not track origins.
----------------
We're missing documentation for these options (e.g. https://clang.llvm.org/docs/MemorySanitizer.html#origin-tracking )



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105128/new/

https://reviews.llvm.org/D105128



More information about the llvm-commits mailing list