[PATCH] D104938: OpaquePtr: Reject 'ptr*' again when parsing textual IR

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 29 12:35:29 PDT 2021


dexonsmith added inline comments.


================
Comment at: llvm/lib/AsmParser/LLParser.cpp:2601
+      if (Result->isOpaquePointerTy())
+        return tokError("ptr* is invalid - use ptr instead");
       if (!PointerType::isValidElementType(Result))
----------------
nikic wrote:
> This breaks pointer to pointer types in `-force-opaque-pointers` mode:
> ```
> define void @test(i32** %x) {}
> ```
> Results in:
> ```
> build/bin/opt: test303.ll:1:23: error: ptr* is invalid - use ptr instead
> ```
Looking.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104938/new/

https://reviews.llvm.org/D104938



More information about the llvm-commits mailing list