[PATCH] D105065: RegAlloc: Fix "SubRange for this mask not found" unreachable in SplitKit

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added a comment.

> I'm suspicious of how simple this patch is, and not sure why this special phi handling is needed given that refineSubRanges was already called

No sure. I am actually thinking that the new version is missing to update the ranges properly when the match is inexact (i.e., aren't we missing some updates?). Previously we had an expectation that the match was exact so the code was correct w.r.t. that simplification. Now, I am not so sure, but maybe like you said this job was actually already done in refineSubRanges.

@kparzysz what do you think?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105065/new/

https://reviews.llvm.org/D105065