[PATCH] D104572: [lit] Add the ability to parse regexes in Lit boolean expressions

[Louis Dionne via Phabricator via llvm-commits]

ldionne marked an inline comment as done.
ldionne added a comment.

In D104572#2847432 <https://reviews.llvm.org/D104572#2847432>, @jdenny wrote:

> LGTM.
>
> I apologize if this is frustrating, but can you wait a couple of days to commit?  I'd like to give other reviewers just a bit more time to comment in case we overlooked something.

Thanks a lot for the review! Waiting for a bit is not frustrating - I fully understand how everybody's busy and I myself often let reviews go under my radar for a while. I'll wait until the end of the week to commit this.



================
Comment at: llvm/docs/TestingGuide.rst:465-468
+- Any Python regular expression enclosed in ``{{ }}``, in which case the boolean
+  expression is satisfied if any feature matches the regular expression. Also note
+  that regular expressions can appear inside an identifier, so for example
+  ``he{{l+}}o`` would match ``helo``, ``hello``, ``helllo``, and so on.
----------------
jdenny wrote:
> Thanks for adding this.
> 
> Tiny nit: The second bullet is a different animal than the other two.  I'd put the other two next to each other or integrate them.  But it's no big deal if you prefer it as is.
Hmm, yes, I agree with you. I integrated both into one paragraph, and I documented the fact that string comparison is case sensitive while I was at it.

Please let me know if the new formulation doesn't suit you.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104572/new/

https://reviews.llvm.org/D104572