[PATCH] D105131: Change the phase ordering of SROA in the LTO to enable more cse opportunities

Tue Jun 29 11:02:13 PDT 2021

jinlin added a comment.

In D105131#2847826 <https://reviews.llvm.org/D105131#2847826>, @lebedev.ri wrote:

> In D105131#2847819 <https://reviews.llvm.org/D105131#2847819>, @jinlin wrote:
>
>> In D105131#2847681 <https://reviews.llvm.org/D105131#2847681>, @lebedev.ri wrote:
>>
>>> This is only changing LTO side of obsolete pass manager.
>>> If that is intentional, i'm not sure it's really worthwhile - it's obsolete pass manager is obsolete.
>>
>> When I added -flto, this pass will be invoked. The LTO is used in the release build at Uber. Why do you think it is obsolete?
>
> Because now the default is the New Pass Manager.

Got you. The new pass manager is enabled by default starting from LLVM 12. I am using xcode 12.4 which uses prior version of llvm.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105131/new/

https://reviews.llvm.org/D105131