[PATCH] D101529: Fix `-Wsuggest-override` warning when building benchmark with clang-cl on Windows

Sibi Siddharthan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 29 10:46:08 PDT 2021


SibiSiddharthan added a comment.

In D101529#2843405 <https://reviews.llvm.org/D101529#2843405>, @kbobyrev wrote:

> Hey! If you're still interested in landing it, please make sure to land it into the upstream first and mention the revision here.

Hey, I have a question. When you say `upstream` do you mean here https://github.com/google/benchmark ?
If so, do I have to raise a pull request there and reference it here?. I do see that the benchmark under the llvm-project has changes that are not present in https://github.com/google/benchmark


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101529/new/

https://reviews.llvm.org/D101529



More information about the llvm-commits mailing list