[PATCH] D103103: [PowerPC][XCOFF] Create 8 and 16 byte aligned constant csects.

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:2391
+  if (Alignment > Align(16))
+    report_fatal_error("Alignments greater then 16 not yet supported.");
+
----------------
s/then/than/;


================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:2398
+
+  if (Alignment == Align(16)){
+    assert(ReadOnly16Section && "Section should always be initialized.");
----------------
Please fix formatting.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-rodata-align.ll:7
+; RUN:   FileCheck %s
+
+
----------------
Would an XCOFF output case be reasonable to test here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103103/new/

https://reviews.llvm.org/D103103