[PATCH] D105124: [ARM][NFC] Remove an unused method

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 29 08:05:15 PDT 2021


ikudrin created this revision.
ikudrin added reviewers: simon_tatham, samparker, ostannard.
ikudrin added a project: LLVM.
Herald added subscribers: danielkiss, dmgreen, hiraditya, kristof.beyls.
ikudrin requested review of this revision.

`ARMInstPrinter::printMveAddrModeQOperand()` was added in D62680 <https://reviews.llvm.org/D62680>, but was never used. It looks like `printT2AddrModeImm8Operand<false>()` is used instead.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D105124

Files:
  llvm/lib/Target/ARM/MCTargetDesc/ARMInstPrinter.cpp
  llvm/lib/Target/ARM/MCTargetDesc/ARMInstPrinter.h


Index: llvm/lib/Target/ARM/MCTargetDesc/ARMInstPrinter.h
===================================================================
--- llvm/lib/Target/ARM/MCTargetDesc/ARMInstPrinter.h
+++ llvm/lib/Target/ARM/MCTargetDesc/ARMInstPrinter.h
@@ -274,8 +274,6 @@
   template<int shift>
   void printMveAddrModeRQOperand(const MCInst *MI, unsigned OpNum,
                                  const MCSubtargetInfo &STI, raw_ostream &O);
-  void printMveAddrModeQOperand(const MCInst *MI, unsigned OpNum,
-                                const MCSubtargetInfo &STI, raw_ostream &O);
   void printMveSaturateOp(const MCInst *MI, unsigned OpNum,
                          const MCSubtargetInfo &STI, raw_ostream &O);
 private:
Index: llvm/lib/Target/ARM/MCTargetDesc/ARMInstPrinter.cpp
===================================================================
--- llvm/lib/Target/ARM/MCTargetDesc/ARMInstPrinter.cpp
+++ llvm/lib/Target/ARM/MCTargetDesc/ARMInstPrinter.cpp
@@ -622,22 +622,6 @@
   O << "]" << markup(">");
 }
 
-void ARMInstPrinter::printMveAddrModeQOperand(const MCInst *MI, unsigned OpNum,
-                                               const MCSubtargetInfo &STI,
-                                               raw_ostream &O) {
-  const MCOperand &MO1 = MI->getOperand(OpNum);
-  const MCOperand &MO2 = MI->getOperand(OpNum + 1);
-
-  O << markup("<mem:") << "[";
-  printRegName(O, MO1.getReg());
-
-  int64_t Imm = MO2.getImm();
-  if (Imm != 0)
-    O << ", " << markup("<imm:") << '#' << Imm << markup(">");
-
-  O << "]" << markup(">");
-}
-
 void ARMInstPrinter::printLdStmModeOperand(const MCInst *MI, unsigned OpNum,
                                            const MCSubtargetInfo &STI,
                                            raw_ostream &O) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D105124.355247.patch
Type: text/x-patch
Size: 1757 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210629/7b79ba07/attachment.bin>


More information about the llvm-commits mailing list