[PATCH] D101074: [X86] Canonicalize SGT/UGT compares with constants to use SGE/UGE to reduce the number of EFLAGs reads. (PR48760)

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.

LGTM, thank you, sorry for so many back and forth here.
Any other comments?



================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:23476
+    // NOTE: Only do this if incrementing the constant doesn't increase the bit
+    // encoding size - so it must stay either an i8 or i32 immediate, and we
+    // don't do this for i64's to avoid additional constant materializations.
----------------
lebedev.ri wrote:
> Comment maybe needs updatind.
Still needs updating


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101074/new/

https://reviews.llvm.org/D101074