[PATCH] D105100: [NFC] Add new setDebugLocFromInst that uses the class Builder

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 29 05:02:39 PDT 2021


sdesmalen added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:552
   /// the instruction.
-  void setDebugLocFromInst(IRBuilder<> &B, const Value *Ptr);
+  void setDebugLocFromInst(IRBuilder<> &B, const Value *Ptr) const;
+
----------------
Is this interface still needed? I expected that the implementation could now use its `Builder` member variable.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:3044
                                Builder.GetInsertPoint());
+
   // Replace the operands of the cloned instructions with their scalar
----------------
unrelated whitespace change?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105100/new/

https://reviews.llvm.org/D105100



More information about the llvm-commits mailing list