[PATCH] D103052: Do not patch FDE symbols in RuntimeDyld, on targets that use non-absolute symbol relocations in `.eh_frame`

Lang Hames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 29 03:22:08 PDT 2021


lhames accepted this revision.
lhames added a comment.
This revision is now accepted and ready to land.

The logic looks good to me. Normally I'd ask for a test case but we don't have a good way to test this at the moment, and I don't think we want to invest in RuntimeDyld testing infrastructure for MachO -- we just want to make sure this works under JITLink instead.

Speaking of which -- did you happen to check whether your test cases worked under JITLink?

- Lang.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103052/new/

https://reviews.llvm.org/D103052



More information about the llvm-commits mailing list