[PATCH] D104967: [llvm-objcopy][MachO] Support ARM64_RELOC_ADDEND

Alexander Shaposhnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 29 01:55:36 PDT 2021


alexander-shaposhnikov accepted this revision.
alexander-shaposhnikov added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/tools/llvm-objcopy/MachO/Object.h:183
   bool Scattered;
+  // True if the type is an ADDEND.
+  bool IsAddend;
----------------
Would be good to expand this comment a little bit explaining the specifics of such relocations
(basically mention that the symbol field actually stores the addend value)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104967/new/

https://reviews.llvm.org/D104967



More information about the llvm-commits mailing list