[PATCH] D104646: [AIX][XCOFF] llvm-readobj 64-bit relocation reading support

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 29 01:17:38 PDT 2021


jhenderson added a comment.

In D104646#2840670 <https://reviews.llvm.org/D104646#2840670>, @MaryamBen wrote:

> I kept one test from llvm-objdump. Is it okey, or I should move it to another patch?

The problem is that you label this patch as "llvm-readobj 64-bit relocation reading support", which suggests this is specific to llvm-readobj. You shouldn't conflate llvm-readobj and llvm-objdump. If the changes in the patch mean that llvm-objdump starts to just work, then consider updating the patch summary.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104646/new/

https://reviews.llvm.org/D104646



More information about the llvm-commits mailing list