[PATCH] D104644: [AIX][XCOFF] Support 64-bit relocation writing and related tests

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 29 01:04:39 PDT 2021


jhenderson added a comment.

I'm not going to be able to contribute much more to this or the related reviews - an XCOFF developer will need to give the sign off on them.



================
Comment at: llvm/test/CodeGen/PowerPC/aix-extern-weak.ll:89
 ; CHECKSYM-NEXT:       StorageMappingClass: XMC_PR (0x0)
-; CHECKSYM-NEXT:       StabInfoIndex: 0x0
-; CHECKSYM-NEXT:       StabSectNum: 0x0
+; CHECKSYM32:          StabInfoIndex: 0x0
+; CHECKSYM32-NEXT:     StabSectNum: 0x0
----------------
Here and everywhere else you've used `CHECKSYM32` or `CHECKSYM64` - should they be `CHECKSYM32-NEXT` and `CHECKSYM64-NEXT`?

Same goes in other similar cases - make sure you to use the -NEXT suffix wherever possible.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104644/new/

https://reviews.llvm.org/D104644



More information about the llvm-commits mailing list