[PATCH] D105055: [llvm-readobj] Make -s and -t match llvm-readelf

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

Seems reasonable to me too. Might be worth an llvm-dev heads-up? Up to you.



================
Comment at: llvm/docs/ReleaseNotes.rst:167-168
 
+* The ``-s`` (``--syms``) and ``-t`` (``--section-details``) options of
+  ``llvm-readobj`` have been changed to match ``llvm-readelf``.
+  (`D105055 <https://reviews.llvm.org/D105055>`_)
----------------
I think this statement is a little unclear could cause some confusion. How about this: "The llvm-readobj short aliases `-s` (previously `--sections`) and `-t` (previously `--syms`) have been changed to `--syms` and `--section-details` respectively, to match `llvm-readelf`."


================
Comment at: llvm/test/tools/llvm-readobj/ELF/merged.test:55
 ## were supported.
-# RUN: not llvm-readobj -aeWhSrnudlVgIs %t.o 2>&1 | FileCheck %s --check-prefix=UNKNOWN
+# RUN: not llvm-readobj -aeWhSrnudlVgIS %t.o 2>&1 | FileCheck %s --check-prefix=UNKNOWN
 
----------------
No need to change this test, I think. You still want `-s` in the list, and you already have `-S` there. You might also want to add `-t`, but it's not really importantn, in my opinion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105055/new/

https://reviews.llvm.org/D105055