[PATCH] D100735: [CodeGen] Enable Windows exception handling for basic block sections

[TaoPan via Phabricator via llvm-commits]

TaoPan added a comment.

In D100735#2845073 <https://reviews.llvm.org/D100735#2845073>, @modimo wrote:

> In D100735#2843362 <https://reviews.llvm.org/D100735#2843362>, @TaoPan wrote:
>
>> In D100735#2842162 <https://reviews.llvm.org/D100735#2842162>, @modimo wrote:
>>
>>> Cool, feel free to file a bug and link it here to track progress.
>>
>> This bug depends on #D99487 and this commit, can't be reproduced without these two commits. Is it ok file the bug after landing these two commits?
>
> In that case it would make sense to fix this in D99487 <https://reviews.llvm.org/D99487>. I pulled this down locally and noticed that baseline testing with BBS hits:
>
> `llc: /home/modimo/llvm-project/llvm/lib/MC/MCStreamer.cpp:1207: virtual void llvm::MCStreamer::SwitchSection(llvm::MCSection *, const llvm::MCExpr *): Assertion `Section && "Cannot switch to a null section!"' failed.`
>
> If you plan on checking this test in early (which I would recommend) before all the other pieces are in place you can replace `RUN` for BBS with a `TODO D99487`.

I set D99487 <https://reviews.llvm.org/D99487> as this patch's parent according to @tmsriram 's comment, it's the reason why the auto test passed but you pull only this down locally and run this test crash. The section of SwitchSection() is created by D99487 <https://reviews.llvm.org/D99487>.
I submitted BBS patches according to purpose:

  D99487 (parent of the below two patches): BBS basic function on Windows
  D100735 (this patch):  BBS exception handling on Windows
  D101421: BBS DebugInfo on Windows

So the upper mentioned bug "with BBS,  build fail with "error: Cannot represent this expression", I'm investigating this error" belongs to this patch.



================
Comment at: llvm/test/MC/COFF/seh-bbs.ll:50
+; COMMON-NEXT:     }
+# 12 BB Sections in BBS, 12 more sections in Section table of BBS
+; BASELINE:          Number: 33
----------------
modimo wrote:
> ";" for comment lines
Thanks! I changed to ";"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100735/new/

https://reviews.llvm.org/D100735