[PATCH] D104968: [llvm-objcopy][MachO] Support LINKER_OPTIMIZATION_HINT

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexander-shaposhnikov added inline comments.


================
Comment at: llvm/tools/llvm-objcopy/MachO/MachOReader.cpp:335
   readDataInCodeData(*Obj);
+  readLinkData(*Obj, Obj->LinkerOptimizationHintCommandIndex,
+               Obj->LinkerOptimizationHint);
----------------
nit: to hide these details one can introduce `readLinkerOptimizationHints`
(similarly to readDataInCode, readFunctionStartsData etc)
which would call this helper method (`readLinkData`) with the right arguments:
   
```
void MachOReader::readLinkerOptimizationHints(Object &Obj) {
    return readLinkData(*Obj, Obj->LinkerOptimizationHintCommandIndex, 
                                     Obj->LinkerOptimizationHint);
}
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104968/new/

https://reviews.llvm.org/D104968