[PATCH] D105044: [lld-macho] Move ICF earlier to avoid emitting redundant binds

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 28 16:41:37 PDT 2021


int3 added inline comments.


================
Comment at: lld/MachO/SyntheticSections.cpp:777
     StabsEntry symStab;
-    symStab.sect = defined->isec->parent->index;
+    symStab.sect = defined->isec->canonical()->parent->index;
     symStab.strx = stringTableSection.addString(defined->getName());
----------------
another benefit of moving ICF earlier: the lack of canonicalization is now obvious, since the `parent` point of coalesced InputSections is null.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105044/new/

https://reviews.llvm.org/D105044



More information about the llvm-commits mailing list