[PATCH] D105064: [llvm-mca] Fix JSON output

[Wolfgang Pieb via Phabricator via llvm-commits]

wolfgangp added inline comments.


================
Comment at: llvm/docs/CommandGuide/llvm-mca.rst:214
+  processor resources are printed as members of special top level JSON objects.
+  The individual views refer to them by index, nonetheles, not all views are
+  printed when using in this format, e.g. bottleneck analysis, timeline view,
----------------
May I suggest another wording:

The individual views refer to them by index. However, not all views are supported. Unsupported
views are not printed, such as bottleneck analysis, etc.


================
Comment at: llvm/docs/CommandGuide/llvm-mca.rst:215
+  The individual views refer to them by index, nonetheles, not all views are
+  printed when using in this format, e.g. bottleneck analysis, timeline view,
+  etc.
----------------
Don't we support the timeline view?


================
Comment at: llvm/tools/llvm-mca/Views/TimelineView.h:184
   json::Value toJSON() const override;
+  bool isSerializable() const override { return false; }
 };
----------------
Like in the comment above, I tought we implemented the timeline view.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105064/new/

https://reviews.llvm.org/D105064