[PATCH] D104937: [Coroutines] Define __coro_frame_ty in function scope

Mon Jun 28 13:43:47 PDT 2021

hoy added a comment.

In D104937#2845235 <https://reviews.llvm.org/D104937#2845235>, @dblaikie wrote:

>> We were seeing a type defined in a local scope causing trouble to the dwarf emitter where a context is required to be a funciton scope, a namespace or a global scope.
>
> Could you describe this in more detail? It's possible there's a bug somewhere there that should be fixed instead of avoiding that situation?

We have encountered an assert failure at the following line, i.e, the `getOrCreateContextDIE` call. 
https://github.com/llvm/llvm-project/blob/main/llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp#L619

Looking into that function (https://github.com/llvm/llvm-project/blob/main/llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp#L538) , I'm not seeing a local scope is supposed to have a DIE created for it. I guess that's by design and dwarf spec.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104937/new/

https://reviews.llvm.org/D104937