[PATCH] D103490: [SystemZ][z/OS] Add support for TXT records in the GOFF reader

Yusra Syeda via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 28 13:37:19 PDT 2021


yusra.syeda marked an inline comment as done.
yusra.syeda added inline comments.


================
Comment at: llvm/lib/Object/GOFFObjectFile.cpp:479
+  if (FillBytePresent)
+    ESDRecord::getFillByteValue(EdEsdRecord, FillByte);
+
----------------
kpn wrote:
> Is this check really needed? If a zero fill byte is wanted then the GOFF fill byte field will be zero.
No, it's not needed. I've updated this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103490/new/

https://reviews.llvm.org/D103490



More information about the llvm-commits mailing list