[PATCH] D105054: [lld/mac] Make lld/test/MachO/tlv.s pass with expensive tests

[Thorsten via Phabricator via llvm-commits]

tschuett added inline comments.


================
Comment at: lld/MachO/OutputSegment.cpp:143
 void OutputSegment::sortOutputSections() {
-  llvm::sort(sections, compareByOrder<OutputSection *>(sectionOrder));
+  llvm::stable_sort(sections, compareByOrder<OutputSection *>(sectionOrder));
 }
----------------
Do you want to add a comment here: it has to be stable_sort ...


================
Comment at: lld/MachO/Writer.cpp:81
   OutputSegment *linkEditSegment = nullptr;
-  DenseMap<NamePair, ConcatOutputSection *> concatOutputSections;
+  MapVector<NamePair, ConcatOutputSection *> concatOutputSections;
 };
----------------
Do you want to add a comment here: The order of bla has to be deterministic or whatever.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105054/new/

https://reviews.llvm.org/D105054