[PATCH] D104997: [WIP][AMDGPU] Deduce attributes with the Attributor

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

@arsenm I'd suggest we get to feature parity with the existing pass, then add more features as needed, then modify the names/polarity as we want it to be. Doing it as part of this will cause too much complexity.



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:27-31
+    "amdgpu-work-item-id-x",  "amdgpu-work-item-id-y",
+    "amdgpu-work-item-id-z",  "amdgpu-work-group-id-x",
+    "amdgpu-work-group-id-y", "amdgpu-work-group-id-z",
+    "amdgpu-dispatch-ptr",    "amdgpu-dispatch-id",
+    "amdgpu-queue-ptr",       "amdgpu-implicitarg-ptr"};
----------------
arsenm wrote:
> These are the attributes as they exist now, but I do think these need to be inverted to be more sound. Assuming they are present is the conservative direction, so ideally we would operate on a no-* basis
I'd recommend to do that in a follow up as this is tested on it's own first, wdyt?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104997/new/

https://reviews.llvm.org/D104997