[PATCH] D100735: [CodeGen] Enable Windows exception handling for basic block sections

Mon Jun 28 12:21:36 PDT 2021

modimo added a comment.

In D100735#2843362 <https://reviews.llvm.org/D100735#2843362>, @TaoPan wrote:

> In D100735#2842162 <https://reviews.llvm.org/D100735#2842162>, @modimo wrote:
>
>> Cool, feel free to file a bug and link it here to track progress.
>
> This bug depends on #D99487 and this commit, can't be reproduced without these two commits. Is it ok file the bug after landing these two commits?

In that case it would make sense to fix this in D99487 <https://reviews.llvm.org/D99487>. I pulled this down locally and noticed that baseline testing with BBS hits:

`llc: /home/modimo/llvm-project/llvm/lib/MC/MCStreamer.cpp:1207: virtual void llvm::MCStreamer::SwitchSection(llvm::MCSection *, const llvm::MCExpr *): Assertion `Section && "Cannot switch to a null section!"' failed.`

If you plan on checking this test in early (which I would recommend) before all the other pieces are in place you can replace `RUN` for BBS with a `TODO D99487`.

================
Comment at: llvm/test/MC/COFF/seh-bbs.ll:50
+; COMMON-NEXT:     }
+# 12 BB Sections in BBS, 12 more sections in Section table of BBS
+; BASELINE:          Number: 33
----------------
";" for comment lines

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100735/new/

https://reviews.llvm.org/D100735