[PATCH] D104569: [SimplifyCFG] Fix SimplifyBranchOnICmpChain to be undef/poison safe.

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 28 11:54:59 PDT 2021


nikic added a comment.

I'm willing to accept the simple patch and see if any regressions are reported. If they are, we can switch to a more sophisticated poison-only approach.



================
Comment at: llvm/lib/Transforms/Utils/SimplifyCFG.cpp:4269
+    if (DTU && DTU->hasDomTree())
+      DT = &DTU->getDomTree();
+
----------------
SimplifyCFG only preserves DT, it should not use it during transforms. You should pass nullptr instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104569/new/

https://reviews.llvm.org/D104569



More information about the llvm-commits mailing list