[PATCH] D104957: Add llvm-readobj and binutils symlinks to LLVM_TOOLCHAIN_TOOLS
Sam Clegg via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 28 10:11:42 PDT 2021
sbc100 added a comment.
In D104957#2844681 <https://reviews.llvm.org/D104957#2844681>, @LittleFox94 wrote:
> llvm-readobj is llvm specific, but readelf is not and llvm-readobj is llvm's implementation of readelf (hence the already existing symlink to it)
>
> Or do you mean we shouldn't make the `readobj` symlink? I added it for completeness, but I didn't see a requirement for it
Yes it seems perhaps unnecessary (and maybe confusing?) to include that symlink.
> Am 28. Juni 2021 19:03:46 MESZ schrieb Sam Clegg via Phabricator <reviews at reviews.llvm.org>:
>
>> sbc100 added a comment.
>>
>> AFAICT `llvm-readobj` is something specific to llvm. There is no
>> `readobj` in binutils or anywhere else is there?
>>
>> Repository:
>>
>> rG LLVM Github Monorepo
>>
>> CHANGES SINCE LAST ACTION
>>
>> https://reviews.llvm.org/D104957/new/
>>
>> https://reviews.llvm.org/D104957
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104957/new/
https://reviews.llvm.org/D104957
More information about the llvm-commits
mailing list