[PATCH] D104409: GlobalISel/Utils: Allow constant match to not match integer constants

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 28 09:31:32 PDT 2021


paquette added a comment.

I'm not sure if I like having //two// toggles here because now people could set `HandleFConstants == false` and `HandleIConstants == false`. :/

I think that it would be nice if we could expose helper functions like so:

- `getIConstantVRegValWithLookThrough` => integer constant case only
- `getFConstantVRegValWithLookThrough` => fp constant case only
- `getAnyConstantVRegValWithLookThrough` => any constant

And then have `getConstantVRegValWithLookThrough` be inaccessible outside of Utils.

This would be a bit more invasive of a change, but I think it would be a readability win overall.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104409/new/

https://reviews.llvm.org/D104409



More information about the llvm-commits mailing list