[PATCH] D104994: [Polly][Isl] Use isl::set::tuple_dim, isl::map::domain_tuple_dim and isl::map::range_tuple_dim. NFC

Mon Jun 28 08:21:41 PDT 2021

Meinersbur added a comment.

The patch includes changes to `isl_map.c`. It looks like that you cherry-picked a change from isl to include here. Please don't diverge the isl sources from upstream.

Usually we commit changes to isl itself separately. Use the script `update-isl.sh` for this. You can commit it separately without review, but ensure that you ran `check-polly` beforehand and add any additional files that were added in the isl repository. See rG842314b5f078b5c63df1d7e271fc6fad8461d44f <https://reviews.llvm.org/rG842314b5f078b5c63df1d7e271fc6fad8461d44f> as an example. Alternatively, ask me to make such a commit.

================
Comment at: polly/lib/Analysis/ScopInfo.cpp:256
 isl::space ScopArrayInfo::getSpace() const {
-  auto Space = isl::space(Id.get_ctx(), 0, getNumberOfDimensions());
+  isl::space Space = isl::space(Id.get_ctx(), 0, getNumberOfDimensions());
   Space = Space.set_tuple_id(isl::dim::set, Id);
----------------
[nit] Change look unrelated

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104994/new/

https://reviews.llvm.org/D104994