[PATCH] D104394: [MachineCopyPropagation] Fix differences in code gen when compiling with -g

Alexandru Octavian Buțiu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 28 07:25:56 PDT 2021


predator5047 added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineCopyPropagation.cpp:829
                     << "\n");
+  llvm::DenseMap<llvm::MCRegister, llvm::MachineInstr *> RegToCopies;
 
----------------
lkail wrote:
> This looks unnecessary, can use `findCopyDefViaUnit` to find out corresponding MachineInstr.
findCopyDefViaUnit or ReadRegister don't work for backwards propagation, because Tracker.trackCopy sets the CopyInfo::MI filed for the source register to null (line 167), so both would always return null.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104394/new/

https://reviews.llvm.org/D104394



More information about the llvm-commits mailing list