[PATCH] D105029: [Debug-info][InstrRef] Avoid un-necessary ordering in debug value-substitution records

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added a comment.

@jmorse Thanks!



================
Comment at: llvm/include/llvm/CodeGen/MachineFunction.h:469
+
+    DebugSubstitution(const DebugInstrOperandPair &Src, const DebugInstrOperandPair &Dest, unsigned Subreg) : Src(Src), Dest(Dest), Subreg(Subreg) { }
+
----------------
I guess this needs clang-format


================
Comment at: llvm/include/llvm/CodeGen/MachineFunction.h:479
 
   /// Substitution map: from one <inst,operand> pair identifying a value,
   /// to a DebugSubstitution identifying another. Used to record changes in
----------------
I guess we need to update this comment as well.


================
Comment at: llvm/include/llvm/CodeGen/MachineFunction.h:483
   /// later.
-  std::map<DebugInstrOperandPair, DebugSubstitution> DebugValueSubstitutions;
+  std::vector<DebugSubstitution> DebugValueSubstitutions;
 
----------------
Can we use `SmallVector` instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105029/new/

https://reviews.llvm.org/D105029