[PATCH] D88891: [DebugInfo][InstrRef][1/4] Support transformations that widen or narrow defined values

[Jeremy Morse via Phabricator via llvm-commits]

jmorse added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/MachineFunction.h:463
+  /// later.
+  std::map<DebugInstrOperandPair, DebugSubstitution> DebugValueSubstitutions;
 
----------------
jmorse wrote:
> djtodoro wrote:
> > Do we need the `std::map` sortness here?
> Hmmm -- not during the optimisation passes, so this can become a vector that gets sorted when lookups occur.
> 
> (I have another patch (not uploaded yet) that might need the sortness, but that can be evaluated in its own right).
I realised that it's already in-tree with a std::map -- I've written D105029 as a separate patch that un-sorts it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88891/new/

https://reviews.llvm.org/D88891