[PATCH] D98591: [CodeGen] Add extension points for TargetPassConfig::addMachinePasses

[Raoul Gough via Phabricator via llvm-commits]

drti added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/TargetPassConfig.h:509
+  /// Target at the given extension point.
+  void applyAnyExtensions(MachinePassExtensionPointTy MPEP);
 };
----------------
ychen wrote:
> I'd prefer to call it `addMachinePassExtentions`.
Well my reasoning was that addExtension "adds" an extension function and "apply" runs the functions (if any). It may also be that a callback doesn't add any passes for a particular target so strictly speaking all we're doing is invoking the callbacks. What do you think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98591/new/

https://reviews.llvm.org/D98591