[PATCH] D104630: [AArch64][CostModel] Add cost model for experimental.vector.splice

[Caroline via Phabricator via llvm-commits]

CarolineConcatto marked 2 inline comments as done.
CarolineConcatto added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:1814
+
+  assert(Kind == TTI::SK_Splice && "Expected Kind Splice");
+  auto AdjustType = [&](MVT M) {
----------------
sdesmalen wrote:
> is it even needed to pass a Kind or Mask in the first place, they seem unused.
Hey Sander,
You are correct about Mask, but Kind is needed.


================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:1815
+  assert(Kind == TTI::SK_Splice && "Expected Kind Splice");
+  auto AdjustType = [&](MVT M) {
+    if (M == MVT::nxv16i1)
----------------
sdesmalen wrote:
> This can be a switch statement instead?
> 
> Also, how about giving the a name like `getPromotedTypeForPredicate` ?
Compiler complains that MVN is not an integer for the switch. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104630/new/

https://reviews.llvm.org/D104630