[PATCH] D105006: [NewPM] Handle passes with params in -print-before/-print-after

[Bjorn Pettersson via Phabricator via llvm-commits]

bjope created this revision.
bjope added reviewers: aeubanks, ychen.
Herald added subscribers: ormris, dexonsmith, hiraditya.
bjope requested review of this revision.
Herald added a project: LLVM.

To support options like -print-before=<pass> and -print-after=<pass>
the PassBuilder will register PassInstrumentation callbacks as well
as a mapping between internal pass class names and the pass names
used in those options (and other cmd line interfaces). But for
some reason all the passes that takes options where missing in those
maps, so for example "-print-after=loop-vectorize" didn't work.

This patch will add the missing entries by also taking care of
function and loop passes with params when setting up the class to
pass name maps.

One might notice that even with this patch it might be tricky to
know what pass name to use in options such as -print-after. This
because there only is a single mapping from class name to pass name,
while the PassRegistry currently is a bit messy as it sometimes
reuses the same class for different pass names (without using the
"pass with params" scheme, or the pass-name<variant> syntax).

It gets extra messy in some situations. For example the
MemorySanitizerPass can run like this (with debug and print-after)

  opt -passes='kmsan' -print-after=msan-module -debug-only=msan

The 'kmsan' alias for 'msan<kernel>' is just confusing as one might
think that 'kmsan' is a separate pass (but the DEBUG_TYPE is still
just 'msan'). And since the module pass version of the pass adds
a mapping from 'MemorySanitizerPass' to 'msan-module' one need to
use 'msan-module' in the print-before and print-after options.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D105006

Files:
  llvm/lib/IR/PassInstrumentation.cpp
  llvm/lib/Passes/PassBuilder.cpp
  llvm/lib/Passes/PassRegistry.def
  llvm/test/Other/print-before-after.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D105006.354815.patch
Type: text/x-patch
Size: 13210 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210628/9f6cd4a0/attachment.bin>